| View previous topic :: View next topic |
| Author |
Message |
Dave
Joined: 06 Apr 2009 Posts: 13
|
Posted: Wed Jan 27, 2010 9:08 pm Post subject: My new site! |
|
|
Just felt like posting. Sorry NZ, I couldn't get your arcade script to work the way I wanted it to. So, I set out on a journey to make my very own! And these are the fruits of my labor, it still needs some work, the site overall and the arcade. I plan on adapting it for both videos and photos.
I could use some C&C and any helpful advice, so tell me what you think of it all!
http://www.Time-Burners.com is the site. |
|
| Back to top |
|
 |
NZ's Finest Site Admin
Joined: 05 Nov 2007 Posts: 245
|
Posted: Mon Feb 01, 2010 2:23 am Post subject: |
|
|
Sorry for the late reply.
Good work, Dave.
A few small suggestions from me:
- Perhaps make the "Click Here To Play Full Screen" link stand out more against the dark background.
- Protect against potential SQL injection by ensuring that only numbers can be entered for the game ID.
An easy way to do this:
| Code: | | $theid = (int)$_GET['gameid']; |
If the user enters something that is not a number, $theid will equal 0.
- If the game doesn't exist (in the database or wherever you store your game information), display an error. For an example, try going to http://www.time-burners.com/arcade/play.php?gameid=9999.
Cheers and good luck with Time Burners . |
|
| Back to top |
|
 |
Dave
Joined: 06 Apr 2009 Posts: 13
|
Posted: Mon Feb 01, 2010 12:01 pm Post subject: |
|
|
| Thanks for that, I was trying to find a way to secure it more, but I just didn't get around to it yet, I also adapted it for photos now. I put the bit of code in that you gave me, and I think I've got it working so that it checks if the game exists, I just have it checking if there is a URL in the sql database for the game. |
|
| Back to top |
|
 |
NZ's Finest Site Admin
Joined: 05 Nov 2007 Posts: 245
|
Posted: Tue Feb 02, 2010 9:11 pm Post subject: |
|
|
Sounds good, Dave.
Good luck with the arcade . |
|
| Back to top |
|
 |
|